[Ffmpeg-devel] [PATCH] Remove special install path for MinGW.
Mon Dec 4 17:56:08 CET 2006
On Mon, Dec 04, 2006 at 10:57:38AM -0500, angustia at arrozcru.no-ip.org wrote:
> Quoting Diego Biurrun <diego at biurrun.de>:
> >On Mon, Dec 04, 2006 at 11:21:35AM -0200, ramiro at lisha.ufsc.br wrote:
> >>I haven't seen any other library that does this install path
> >>special-casing for Windows, and FFmpeg seems like it should be the last
> >>program to support such a thing.
> >This is due to the way MinGW cross-compilation is handled in configure.
> >I've always been tempted to remove it. In any case your patch is
> >incorrect as --prefix will no longer work correctly.
> I don't understand how it will no longer work correctly. My rationale
> was "let it be dealt with by default like it should be". Could you be
> more specific as to how --prefix will no longer work correctly?
The value of --prefix is checked before, so setting PREFIX later will
hardcode it without allowing --prefix to override it.
> --- configure (revision 7221)
> +++ configure (working copy)
> @@ -1486,8 +1483,8 @@
> # Ugh, avisynth uses WINAPI calls. Generic tests won't work.
> if enabled avisynth; then
> - temp_extralibs -lvfw32
> - check_ld <<EOF && add_extralibs -lvfw32 || die "ERROR: vfw32 not found"
> + temp_extralibs -lavifil32
> + check_ld <<EOF && add_extralibs -lavifil32 || die "ERROR: avifil32 not found"
Don't bother sending in a new patch with this hunk removed, though. The
idea of your patch is incorrect.
More information about the ffmpeg-devel