[Ffmpeg-devel] [PATCH] Correct inttypes.h emulation for Visual Studio
Tue Dec 5 09:28:17 CET 2006
Reimar D?ffinger wrote:
> On Mon, Dec 04, 2006 at 02:12:47AM +0300, Alexander Chemeris wrote:
>> Are you agree to adding MS-specific inttypes as separate header to FFMpeg
>> source tree?
> I guess linking one from the FAQ (there is already a FAQ section I
> think) would be okay.
> But neither the problem nor the solution are really ffmpeg-specific...
I have to agree with this. Though actually, the documentation section
already links to a wiki about using libav* under windows. Why doesn't
someone just adjust the patch so it can be used as a standalone
inttypes.h for MSVC, and post it on the wiki telling people to put it in
their include directory where all projects can take advantage of it, and
attach some disclaimer that says the FFMpeg devs don't support it, and
don't guarantee it'll work right, not break things, not eat peoples'
Though I'm a little curious as to what the exact criteria are for such a
workaround for non C99 compliant compilers. The recent patch to avoid
using llrint because it's not supported on some systems didn't get any
opposition due to the fact that llrint is a C99 function and therefore
should be available. Granted, it doesn't seem to be applied yet either,
but it didn't get any opposition related to C standards.
Though I do think a missing inttypes.h is a more grievous fault,
especially when MS does apparently provide equivalent, yet differently
named typedefs already.
More information about the ffmpeg-devel