[Ffmpeg-devel] [PATCH] support S302M streams in MPEG TS

[Reimar Döffinger]

Hello,

I just noticed something that annoys me quite a bit:

On Fri, Dec 01, 2006 at 11:58:21AM +0100, Baptiste Coudurier wrote:
> +    if (s->frame_size > 0) {
> +        memcpy(s->inbuf_ptr, buf, buf_size);
> +        s->inbuf_ptr += buf_size;
> +        if (s->inbuf_ptr - s->inbuf == s->frame_size) {

Why this buffering? It costs speed, adds complexity and is completely
unneeded for the daud demuxer, isn't it?
That kind of thing (i.e. framing) is what AVParsers are usually there
for.

Greetings,
Reimar D?ffinger