[Ffmpeg-devel] [PATCH] Allow choosing display and screen number for x11grab device
Wed Dec 13 22:58:59 CET 2006
On Wed, Dec 13, 2006 at 10:32:21PM +0100, Panagiotis Issaris wrote:
> > ffmpeg -vd x11:0.1 -s 640x480 test.avi
> Furthermore, I think there are some errorhandling problems, which I did not want
> to fix in the same patch, as I wanted to address separate issues in separate
This is an incremental patch with my first try to fix these error handling
problems. I'm not sure if this is the correct way to handle errors as I am a
Xlib-newbie. It seemed cleaner to me to release resources if things fail after
some allocations succeeded. Furthermore, there's a lot of code duplication,
which in Linux is avoided by using gotos :) I could also make a function that is
called on every failure and does all the releasing using one "if (!...)"
condition per call.
With friendly regards,
-------------- next part --------------
A non-text attachment was scrubbed...
Size: 2844 bytes
Desc: not available
More information about the ffmpeg-devel