[Ffmpeg-devel] [PATCH] qcelp codec supporrt

Moriyoshi Koizumi koizumi
Wed Dec 13 23:14:42 CET 2006


On Mon, 2006-12-11 at 10:06 +0100, Benjamin Larsson wrote:
> Moriyoshi Koizumi skrev:
> > Hello,
> >
> > I implemented avcodec stub code that glues ffmpeg with the reference
> > implementation of QCELP which is provided in the 3GPP2 project page.
> >
> > Any comments are welcome.
> >   
> 
> Is the qcelp.h file missing ? And I think it would be better to do the 
> building in 2 steps like how it's done with the AMR RI. Ie include a 
> custom makefile that builds and patches the ref source properly. And 
> then just let ffmpeg link to the files when building as usual. There 
> wouldn't be any need to download the patch seperatly then.

Right, I totally forgot to create qcelp.h in the first place, as it's
worked even without it :)

The two step build system is obviously better to have and then I'm
working on it.

Thanks for the comment.

-- 
Moriyoshi Koizumi (?? ??)
GREE, Inc.





More information about the ffmpeg-devel mailing list