[Ffmpeg-devel] [PATCH] Allow choosing display and screen number for x11grab device

[Panagiotis Issaris]

Hi,

On Fri, 2006-12-15 at 11:05 +0100, Michael Niedermayer wrote:
>[...]
> > +        displayname = av_malloc(len+1);
> > +        if (!displayname)
> > +            return -ENOMEM;
> > +        strncpy(displayname, param, len);
> > +        displayname[len] = '\0';
> > +    } else
> > +        displayname = av_strdup(param); /* if displayname becomes NULL, default display will be taken */
> 
> param = av_strdup(param);
> offset = strchr(param, '+');
> if (offset) {
>     sscanf(offset, "%d,%d", &x_off, &y_off);
>     *offset= 0;
> }
> 
> except that patch ok
Thanks! Committed.

Is it worth having another look at the error handling and freeing
resources?

With friendly regards,
Takis
-- 
vCard: http://www.issaris.org/pi.vcf
Public key: http://www.issaris.org/pi.key