[Ffmpeg-devel] [PATCH] get rid of AVFrac

Baptiste Coudurier baptiste.coudurier
Sat Dec 16 01:29:48 CET 2006


Hi

Michael Niedermayer a ?crit :
> Hi
> 
> On Sat, Oct 14, 2006 at 07:01:59PM +0200, Reimar D?ffinger wrote:
>> Hello,
>> On Fri, Oct 13, 2006 at 09:33:18PM +0200, Michael Niedermayer wrote:
>> [...]
>>> this doesnt look correct ...
>> Hmm.. well, no idea what exactly the old code does and how.
>> Here is another try, it's the best I can do without further hints.
> 
> [...]
> 
> so what the code does is it simply fills in missing timestamps on
> the encoding side and it does so without rounding errors assuming
> constant framerate and a few other things allthough
> the usefullness of the whole is questionable (the user app should set
> the timestamps and not leave it to lav* to guess something)
> 
> [...]
> 
> IMHO drop "support" for missing dts on the encoder side completely it makes
> no sense at all, its like sending emails with no To: field
> 

Here is an updated patch which drop support for missing pts or dts on 
the encoder side.

However ffmpeg.c does not compile anymore, and Im not sure to know 
exactly what ffmpeg.c does, could st->pts be updated to use rescaled 
st->cur_dts ? Seems that cur_dts would only be 1 frame less that 
st->pts.val in that case, maybe Im wrong.

-- 
Baptiste COUDURIER                              GnuPG Key Id: 0x5C1ABAAA
Key fingerprint                 8D77134D20CC9220201FC5DB0AC9325C5C1ABAAA
checking for life_signs in -lkenny... no
-------------- next part --------------
An embedded and charset-unspecified text was scrubbed...
Name: avfrac.patch
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20061216/c509c043/attachment.txt>



More information about the ffmpeg-devel mailing list