[Ffmpeg-devel] [PATCH] asf-enc brokes packets with padding

Michael Niedermayer michaelni
Tue Dec 19 17:39:30 CET 2006


On Tue, Dec 19, 2006 at 01:25:45PM +0200, Nikolay Dobrev wrote:
> Hello,
> Encoding of asf packets with padding is broken.
> When asf->packet_size_left is not zero, one or two more bytes is added to
> the parsing info and the asf->packet_size_left is not updated. Then the
> packet_filled_size in function
> static void flush_packet(AVFormatContext *s)
> is wrong and the memset:
> memset(asf->packet_buf + packet_filled_size, 0, asf->packet_size_left);
> fills the end of the frame with zeroes. After that when the file is played
> there is errors from the decoder of these frames.
> I suggest the attached patch.

you ve already posted this patch 3days ago, and ive reviewed it, please read
the review in the mailinglist archives if you wherent subscribed

Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

No evil is honorable: but death is honorable; therefore death is not evil.
-- Citium Zeno

More information about the ffmpeg-devel mailing list