[Ffmpeg-devel] Re: [PATCH] file length handling
Tue Dec 19 17:57:35 CET 2006
On Mon, Dec 18, 2006 at 09:11:55PM -0500, Ronald S. Bultje wrote:
> Hi Michael,
> On Mon, 2006-12-18, Michael Niedermayer wrote:
> > On Mon, Dec 18, 2006 at 08:55:43PM +0100, Ronald S. Bultje wrote:
> > > On Mon, 18 Dec 2006, Michael Niedermayer wrote:
> > > > On Mon, Dec 18, 2006 at 09:20:49AM -0500, Ronald S. Bultje wrote:
> > > > > -#define LIBAVFORMAT_VERSION_INT ((51<<16)+(6<<8)+0)
> > > > > -#define LIBAVFORMAT_VERSION 51.6.0
> > > > > +#define LIBAVFORMAT_VERSION_INT ((52<<16)+(0<<8)+0)
> > > > > +#define LIBAVFORMAT_VERSION 52.0.0
> > > > > #define LIBAVFORMAT_BUILD LIBAVFORMAT_VERSION_INT
> > external or not how does adding a field to the end break anyting?
> > no external code should depend on any struct size if it does its
> > broken IMHO
> I don't add it to the end. URLContext has a char filename at the end,
> which is used for dynamic sizing of the struct.
you are right :(
i (and i belive many of our users too) would prefer if compatibility wouldnt
be broken, its broken often enough anyway
so either we put the addition of filesize under
#if LIBAVFORMAT_VERSION_INT > ...
or we find some alternative, like performing the actual seek in read()
instead of seek() for http?
note, we will likely need to bump the major version number for the removial
of AVFrac so the #if LIBAVFORMAT_VERSION_INT > ... would likely just be
there for a short time
and independant of all that it would be nice if char filename could be
changed to char *filename in the next major version bump so this issue
wont happen again
> [.. confusion about 0 and -1 for file_size ..]
> > ok, but please document that with a doxygen comment for file_size
> Added (kind of extensive, hope it's not too long). New patch attached
> (also removes the cosmetic change in the previous patch).
the comment is ok
Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB
Those who are too smart to engage in politics are punished by being
governed by those who are dumber. -- Plato
More information about the ffmpeg-devel