[Ffmpeg-devel] [PATCH] Vorbis I floor type 0 support
Fri Feb 3 08:44:48 CET 2006
On Fri, Jan 27, 2006 at 06:14:35PM +0100, Alexander Strasser wrote:
> Alexander Strasser wrote:
> > Benjamin Larsson wrote:
> > > Indentation. It's some more also.
> > Right, there were some more remaining style errors than i thought.
> > ( This happens when you look at your own code too many times ^^" )
> > Hopefully i caught all of them now; new patch attached.
> Sorry, really attached now.
> + vorbis_floor_decode_func floor_decode;
You used a single a variable for pointer to decode function. There's no
garuntee anywhere in the Vorbis spec that all floors in a single file are
the same type. You should make this variable in the floor sturct, and per
Other than that, I like this patch... Only thing missing making FFmpeg
Vorbis decoder complete...
More information about the ffmpeg-devel