[Ffmpeg-devel] [PATCH] Fixes for Darwin/x86

[Michael Niedermayer]

Hi

On Wed, Feb 08, 2006 at 12:27:41PM +0100, Dan Villiom Podlaski Christiansen wrote:
> 
> On 08/02/2006, at 11.16, Diego Biurrun wrote:
> 
> >On Wed, Feb 08, 2006 at 09:09:36AM +0100, Dan Villiom Podlaski  
> >Christiansen wrote:
> >>On 08/02/2006, at 1.38, Michael Niedermayer wrote:
> >>
> >>>>While at it, I made a minor change in the way PIC is defined on
> >>>>Darwin.
> >>>
> >>>how is this related to the align stuff? this should be a seperate
> >>>patch ...
> >>
> >>It is related to getting the i386 parts compiling on Darwin/x86. Only
> >>the x86-specific code checks whether PIC is defined, so there has
> >>been no need to define it until now. This is a necessary fix for
> >>getting dynamic builds working on Darwin/x86, although it's not  
> >>enough.
> >
> >But you enable it not only for x86 ...
> 
> Yes, I assumed that it should be enabled whenever PIC was used. The  
> attach patch fixes it to only be enabled when compiling for Darwin/x86.

[...]

> +if test "$targetos" = "Darwin"; then
> +  if "$cpu" = "x86"; then
> +    SHCFLAGS="$CFLAGS -DPIC"
> +  else
> +    SHCFLAGS="$CFLAGS"
> +  fi
> +  if test "$needmdynamicnopic" = yes; then
> +    CFLAGS="$CFLAGS -mdynamic-no-pic"
> +  elif "$cpu" = "x86"; then
> +    CFLAGS="$CFLAGS -DPIC"
> +  fi

what does -mdynamic-no-pic do? the no-pic in the name suggests to me that no
PIC code is generated, if so -DPIC is wrong, but this mess will set 
SHCFLAGS="$CFLAGS -DPIC" CFLAGS="$CFLAGS -mdynamic-no-pic" in some cases


> 
> Also, the ASMALIGN() macros where moved into a defined(ARCH_X86) ||  
> defined(ARCH_X86_64) conditional, to ensure that they weren't defined  
> when not needed.

rejected, i already said they are not x86 specific

[...]

-- 
Michael