[Ffmpeg-devel] Re: [PATCH] x264 avc encoding, movenc avcC, ctts

[Baptiste COUDURIER]

Michael Niedermayer wrote:
> [...]
> no this is wrong pts-dts does not need to be a multiple of pkt->duration
> 

They actually are, at least with one sample I have here.

> the correct code IMHO is trk->cluster[cl][id].cts= (pkt->pts - pkt->dts) * enc->time_base.num;
> though i didnt check the spec ...

I totally agree. I just observed that pts-dts was a multiple of
pkt->duration.

> also note that mov_write_stts_tag() is totally wrong, it must store the dts
> not blindly assume they are all equally spaced
> 
> [...]

I totally agree. Point is that it is done this way atm. I agree that
building over something wrong is stupid, but creating 'stts' that way
basically 'works'. What do you suggest ?

-- 
Baptiste COUDURIER                              GnuPG Key Id: 0x5C1ABAAA
SMARTJOG S.A.                                    http://www.smartjog.com
Key fingerprint                 8D77134D20CC9220201FC5DB0AC9325C5C1ABAAA
Phone: +33 1 49966312