[Ffmpeg-devel] Re: [MPlayer-users] Re: BUGREPORT: Error in [ffmpeg] FFmpeg/libavcodec audio decoders (RealAudio)

[matthieu castet]

Hi,

Neil Sleightholm wrote:
> Neil Sleightholm wrote:
> 
> 
>>A recent update has broken the play back of some real audio streams.
>>If you play the stream:
>>http://www.bbc.co.uk/radio1/realaudio/media/r1live.rpm you get the
>>following error:
>>
>>	Opening audio decoder: [ffmpeg] FFmpeg/libavcodec audio decoders
>>	subbands > 34 or js_subband_start > 19, report sample!
>>	Could not open codec.
>>
>>This happens with this version: MPlayer dev-CVS-060107-09:51-3.4.2
>>
>>Neil
> 
> 
> Update: The error is happening because this stream has "subbands = 37".
> The patch below fixes this:
> 
> Index: libavcodec/cook.c
> ===================================================================
> RCS file: /cvsroot/ffmpeg/ffmpeg/libavcodec/cook.c,v
> retrieving revision 1.4
> diff -u -r1.4 cook.c
> --- libavcodec/cook.c	6 Jan 2006 12:41:57 -0000	1.4
> +++ libavcodec/cook.c	7 Jan 2006 15:51:38 -0000
> @@ -1277,8 +1277,8 @@
>          av_log(NULL,AV_LOG_ERROR,"total_subbands > 53, report
> sample!\n");
>          return -1;
>      }
> -    if (((q->subbands > 34) || (q->js_subband_start > 19)) &&
> (q->joint_stereo)) {
> -        av_log(NULL,AV_LOG_ERROR,"subbands > 34 or js_subband_start >
> 19, report sample!\n");
> +    if (((q->subbands > 40) || (q->js_subband_start > 19)) &&
> (q->joint_stereo)) {
> +        av_log(NULL,AV_LOG_ERROR,"subbands > 40 or js_subband_start >
> 19, report sample!\n");
>          return -1;
>      }
>      if (q->subbands > 50) {
> 
> 
> Could this be applied to CVS?
> 
If you post the patch on the right mailling list (ffmpeg), it should be 
more easier for the developpers to review your patch.

Thanks

Matthieu