[Ffmpeg-devel] [PATCH] portability fixes (ILP32 vs LP64)
Wed Jan 18 20:21:46 CET 2006
M?ns Rullg?rd <mru at inprovide.com> writes:
> Dieter <freebsd at sopwith.solgatos.com> writes:
>> Here are fixes for some of the compiler warnings I got
>> building the cvs version of ffmpeg on FreeBSD 6.0.
>> They should help with portability between ILP32 and LP64.
>> Diffs for file: libavcodec/i386/h264dsp_mmx.c
>> RCS file: RCS/h264dsp_mmx.c,v
>> retrieving revision 1.1
>> diff -u -c -r1.1 h264dsp_mmx.c
>> *** h264dsp_mmx.c 2006/01/18 01:15:54 1.1
>> --- h264dsp_mmx.c 2006/01/18 17:06:06
>> *** 65,70 ****
>> --- 65,75 ----
>> "packuswb "#z", "#p" \n\t"\
>> "movd "#p", (%0) \n\t"
>> + /* prototypes */
>> + void ff_h264_idct_add_mmx2(uint8_t *, int16_t *, int);
>> void ff_h264_idct_add_mmx2(uint8_t *dst, int16_t *block, int stride)
> Apart from being useless, that prototype is simply wrong. This code
> shouldn't even compile. The rest of the added prototypes are only
Forget that. I can't read today.
> useless, AFAICS. The rest of the patch is unreadable. Send a unidiff
> M?ns Rullg?rd
> mru at inprovide.com
mru at inprovide.com
More information about the ffmpeg-devel