[Ffmpeg-devel] [PATCH] MP4 and MOV encoder support for files > 4GB
Michael Niedermayer
michaelni
Mon Jan 23 15:12:38 CET 2006
Hi
On Mon, Jan 23, 2006 at 12:50:48PM +0100, Dirk Musfeldt wrote:
> Hi,
>
> > Hi
> >
> > On Mon, Jan 16, 2006 at 01:28:02PM +0100, Dirk Musfeldt wrote:
> >> Hi,
> >>
> >> OK, these are the modified regression tests...
> > [...]
> >>>
> >>>> + if (j < UINT32_MAX) {
> >>>> + url_fseek(pb, mov->mdat_pos, SEEK_SET);
> >>>> + put_be32(pb, j+8);
> >>>
> >>> j=UINT32_MAX - 1 -> j+8 > UINT32_MAX
> >
> > and this issue?
> >
> > if j is UINT32_MAX - 1 the body of the if() will be executed and j+8 will
> > be stored but that is larger then UINT32_MAX and will overflow or did i
> > miss something which prevents this?
> >
> > [...]
>
> No, of course you're right and I forgot to react on this issue from your
> first mail. :-/
>
> I changed this to
>
> + if (j+8 <= UINT32_MAX) {
> + url_fseek(pb, mov->mdat_pos, SEEK_SET);
> + put_be32(pb, j+8);
>
>
> Please see the attached diff file.
applied
[...]
--
Michael
More information about the ffmpeg-devel
mailing list