[Ffmpeg-devel] [PATCH] from DivX, Part 2: Multifile source

Michael Niedermayer michaelni
Wed Jan 25 12:40:14 CET 2006


Hi

On Fri, Dec 16, 2005 at 12:28:02PM -1000, Steve Lhomme wrote:
> There was a missing part, here it is.
> 
> Steve Lhomme wrote:
> >This patch adds a new protocol input to do the simulation of file 
> >concatenation (not always available when you use the ffmpeg library).
> >
> >It should work on other OS too.
> >
> >The URL to use is : "multi:<file1>*<file2>*"
> >
> >It's mostly used for merging MPEG (VOB) files on the fly.

does this has any advantage over 
cat a b c | ffmpeg?


[...]

> +#define IO_MULTI_FILE_PROTO  "multi:"

reanme to "cat" IMHO as its not really supporting multiple files 
(avi for example)


> +#define IO_MULTI_FILE_SEPAR  '*'

IMHO a '*' is a uncommon choice as seperator, what about : or , ?


[...]

> +static offset_t fileconcat_seek(URLContext *h, offset_t pos, int whence)
> +{
> +    size_t i,j;
> +    offset_t result = -1;
> +    struct fileconcat_info *finfo = (struct fileconcat_info *) h->priv_data;
> +    switch (whence)
> +    {
> +        case SEEK_END:
> +            assert(pos == -1 || pos == 0); /* other cases not supported */

is it really so hard to jump to SEEK_SET below to handle this correctly?

[...]

-- 
Michael





More information about the ffmpeg-devel mailing list