[Ffmpeg-devel] [PATCH] from DivX, Part 7: MSVC fixes
Thu Jan 26 07:04:44 CET 2006
On Thu, Jan 26, 2006 at 12:39:46AM +0100, Michael Niedermayer wrote:
> On Wed, Jan 25, 2006 at 01:30:44PM -1000, Steve Lhomme wrote:
> > Michael Niedermayer wrote:
> > >>>would be cleaner but even then i would say that needs some disscussion
> > >>>and
> > >>>should be a seperate patch
> > >>Given __align8(type, var) was rejected because it's "unreadable", I
> > >>don't think this macro would qualify neither. Other than that, I agree
> > >>this is a better long-term change.
> > >
> > >who rejected __align8(type, var)? i didnt or at least i dont remember it
> > I think Felker was the one against it.
I don't have the authority to reject, just the authority to flame. :)
> __align8(type, var) is ok, ill apply it if you send a patch with it
I was against it because it's not even obvious that this is a variable
declaration without reading the #define.
Also, using __ prefix is illegal. __ is reserved for the
implementation. For all you know, the C library/compiler might define
__align8 for its own purposes. You should use align8 or something not
in the reserved namespace at the very least.
BTW a portable way to align memory on the stack at 8-byte boundary is
to declare it as type double. :) Not sure this works, but it should..
More information about the ffmpeg-devel