[Ffmpeg-devel] Re: [PATCH] portability fixes (ILP32 vs LP64)

Michael Niedermayer michaelni
Fri Jan 27 15:45:06 CET 2006


Hi


On Thu, Jan 26, 2006 at 10:58:30PM +0000, Dieter wrote:
> Prototypes either moved to .h file or changed to static.

good


[...]
> -#if 1
> -#define FILTER_SHIFT 15
> -
> -#define FELEM int16_t
> -#define FELEM2 int32_t
> -#define FELEM_MAX INT16_MAX
> -#define FELEM_MIN INT16_MIN
> -#else
> -#define FILTER_SHIFT 22
> -
> -#define FELEM int32_t
> -#define FELEM2 int64_t
> -#define FELEM_MAX INT32_MAX
> -#define FELEM_MIN INT32_MIN
> -#endif

iam against this change


[...]
> +++ avformat.h	2006/01/26 22:45:46
> @@ -713,5 +713,7 @@
>  }
>  #endif
>  
> +int gif_write(ByteIOContext *, AVImageInfo *);

the image code in avformat is going to be moved to libavcodec, and we will
forget this one if we add it now, so iam against this one


[...]
> + /* prototypes */
> +double av_int2dbl(int64_t);
> +float av_int2flt(int32_t);
> +int64_t av_dbl2int(double);
> +int32_t av_flt2int(float);

these are in libavutil/intfloat_readwrite.h


> +double bessel(double);

only used in resample2.c


[...]

> +void ff_spatial_dwt(int *, int, int, int, int, int);

should be put in dsputil.h


> +void parse_arg_file(const char *);

its in cmdutils.h


> +uint16_t a52_crc16_block(uint8_t *, uint32_t);

its in a52_util.h

please search the existing headers before adding stuff

[...]

-- 
Michael





More information about the ffmpeg-devel mailing list