[Ffmpeg-devel] [PATCH] part 8 - portability fixes (ILP32 vs LP64)
Mon Jan 30 11:24:47 CET 2006
Wolfram Gloger said:
>> Dieter <freebsd at sopwith.solgatos.com> writes:
>> > -uint16_t getbe16(const uint8_t *p)
>> > +static uint16_t getbe16(const uint8_t *p)
>> This does nothing for portability, and has nothing to do with
> Namespace pollution does affect portablity.
It affects portability in that it reduces the risk of name clashes. That
has nothing to do with machine word size.
> Please, this patch (part
> 8) is obviously correct and should be applied. I have no idea how the
> non-static versions could get there (shame on me).
All the +static patches are OK and should be applied. What I'm complaining
about is the inaccurate descriptions.
mru at inprovide.com
More information about the ffmpeg-devel