[Ffmpeg-devel] [PATCH] part12 resend - fixes for compiler warnings

The Wanderer inverseparadox
Tue Jan 31 02:26:21 CET 2006

Dieter wrote:

>> All your patches got corrupted by your broken mailer.
> Patches 12 and 18 got corrupted, but not by my mailer. Guess again.
> :-)
> Here is part 12 again, hopefully correct this time:

It may be correct as far as applying goes (it works for me), but there
are still two problems.

First, you are still sending the patch inline, instead of as an
attachment. Inline text can be corrupted by either the sender's or the
receiver's mail client (adding and removing newlines, primarily);
attached files are not subject to the same problem. Also, it is easier
to get the patch into a usable location if it is attached (save the
attached file) than if it is inline (copy the inline text, open a text
editor, paste the copied text, save the file).

> Diffs for file: libavcodec/snow.c
> ===================================================================
> RCS file: RCS/snow.c,v
> retrieving revision 1.1
> diff -u -r1.1 snow.c
> --- snow.c      2006/01/26 21:03:39     1.1
> +++ snow.c      2006/01/26 21:32:47

Second: as you can see, this patch was made from within the libavcodec/
directory, rather than from the root of the FFmpeg source tree. This
makes it less convenient to apply, whether for testing or to commit. I
know that the MPlayer rule is that patches should be made from the root
of the source tree, and I think that FFmpeg uses the same policy...

       The Wanderer

Warning: Simply because I argue an issue does not mean I agree with any
side of it.

Secrecy is the beginning of tyranny.

More information about the ffmpeg-devel mailing list