[Ffmpeg-devel] time for a release?

Bryan Mayland bmayland
Tue Jan 31 14:18:18 CET 2006


Diego Biurrun wrote:
>> [PATCH] ffserver warning cleanup 01/20/06
>> should be checked/applied.
>>     
>
> What about this one?  Mans, you are the warnings guy, can you
> check/apply it?
>   

About those, Micheal Niedermayer said:
"rejected, these silly signed/unsigned casts make the code less readable 
feel free to send a patch which disables/filters these warnings or 
change the actual types where its correct and possible"

I have no other solution for the issue, considering it is a buffer used 
as a raw unsigned byte buffer some places and as a char buffer in others 
(depending on if ffserver is writting to http header or body).  
Splitting the buffer into two buffers (one uint8_t, one char) would be 
pointless, changing the type to one or the other would still give 
warnings, and using something to disable the warnings is just a bad 
idea.  Consider this patch dead unless someone has a better idea.

I'm more concerned with my:
[PATCH] Fix leak of AVPacket data in ffserver Jan 24, 2006
However, the patch I submitted assumed the inclusion of the warnings 
patch from above.  I'll resubmit if it will be applied.





More information about the ffmpeg-devel mailing list