[Ffmpeg-devel] [PATCH] Make use of GCC's __PIC__ definition when available
Diego 'Flameeyes' Pettenò
Sat Jul 1 19:27:29 CEST 2006
On Saturday 01 July 2006 16:36, M?ns Rullg?rd wrote:
> > BeOS)
> > prefix="/boot/home/config"
> > # helps building libavcodec
> > -CFLAGS="$CFLAGS -DPIC -fomit-frame-pointer"
> > +CFLAGS="$CFLAGS -D__PIC__=1 -fomit-frame-pointer"
> This looks wrong. What's that -DPIC doing there at all?
Well, that is something I don't have an answer to... I just made sure it
behave in the same way.
> You should include a dummy variable or function definition in case the
> compiler doesn't like empty input files.
Point taken, will refresh the local copy now, I'll wait for an answer to the
thing below before resending.
> > -#ifndef PIC
> > +#if ! __PIC__
> This generates a warning if __PIC__ is undefined, although I think it
> is allowed by C99.
I'm told it works fine also in C89, if that is the problem. GCC seems not to
throw any warning here. Is there some other compiler you know will throw
Diego "Flameeyes" Petten? - http://farragut.flameeyes.is-a-geek.org/
Gentoo/Alt lead, Gentoo/FreeBSD, Video, AMD64, Sound, PAM, KDE
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Size: 189 bytes
Desc: not available
More information about the ffmpeg-devel