[Ffmpeg-devel] [PATCH] rename CONFIG_WIN32 to CONFIG_MINGW/__MINGW32__
Wed Jul 12 13:09:42 CEST 2006
On Tue, Jul 11, 2006 at 03:12:51PM +0200, Diego Biurrun wrote:
> On Tue, Jul 11, 2006 at 11:30:52AM +0100, M?ns Rullg?rd wrote:
> > Diego Biurrun said:
> > > On Mon, Jul 10, 2006 at 07:39:43PM +0100, M?ns Rullg?rd wrote:
> > >>
> > >> Fine by me in general, assuming the compiler defines __MINGW32__.
> > >
> > > We define it in configure.
> > No, we don't, and we must not define anything starting with and underscore.
> > Such names are reserved for the system. GCC seems to define __MING32__
> > automatically though.
> Maybe we must not, but we sure do, look at configure line 1924:
> if test "$mingw32" = "yes" ; then
> echo "#ifndef __MINGW32__" >> $TMPH
> echo "#define __MINGW32__ 1" >> $TMPH
> OK, this may be another bug then ...
Is this possibly needed for crosscompilation? Since it's protected by
#ifndef it's probably not a big deal.
> Dunno if this simplifies much, but I'll commit both patches when I come
> home this evening.
More information about the ffmpeg-devel