[Ffmpeg-devel] [PATCH] '/nop' illegal for old versions of GAS

Nigel Pearson nigel
Mon Jul 24 03:34:24 CEST 2006

Purpose: Allow simple_idct_mmx.c to compile on Intel OS X/Darwin
Applies: SVN r5816
Testing: Since March by various anonymous Wiki users,
          Myself for a few weeks
Authors: Sam Hocevar, Nigel Pearson

Discussion: The IDCT C-source macros in simple_idct_mmx.c
have a "rounder" argument whose /nop value causes problems:

cc -O3  -no-cpp-precomp -pipe -force_cpusubtype_ALL -Wno-sign-compare 
-fomit-frame-pointer -g -Wdeclaration-after-statement -Wall -Wno-switch 
-mdynamic-no-pic -DHAVE_AV_CONFIG_H -I.. 
-I/Users/nigel/ffmpeg/libavutil -D_FILE_OFFSET_BITS=64 
-D_LARGEFILE_SOURCE -D_ISOC9X_SOURCE    -c -o i386/simple_idct_mmx.o 
{standard input}:410:Junk character 47(/)
{standard input}:410:Rest of line ignored. 1st Junk character valued 
110 (n).

Changing the argument to either #nop or "nop" allows
compilation on Intel OS X/Darwin (which uses as 1.38).
The "nop" form is illegal on Linux GAS (e.g. 2.15).

Note that, since the rounder arg has no impact
(it is always being used as a comment),
we could just as easily remove it from all macros.
But I will leave that as an exercise to the committer :-)

% svn diff libs/libavcodec/i386/simple_idct_mmx.c > 

Nigel Pearson, nigel at ind.tansu.com.au|"Now the world has gone to bed,
Telstra Net. Eng., Sydney, Australia | Darkness won't engulf my head,
Office: 9202 3900    Fax:  9261 3912 | I can see by infrared,
Mobile: 0408 664435  Home: 9792 6998 | How I hate the night." -Marvin
-------------- next part --------------
A non-text attachment was scrubbed...
Name: patch.osxintel-2.diff
Type: application/octet-stream
Size: 6072 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20060724/5e5a3fd7/attachment.obj>

More information about the ffmpeg-devel mailing list