[Ffmpeg-devel] [PATCH] fix ogg seeking
Mon Jul 24 08:42:16 CEST 2006
On Sun, Jul 23, 2006 at 08:20:56PM +0200, Reimar D?ffinger wrote:
> On Sun, Jul 23, 2006 at 11:05:36AM +0200, Reimar D?ffinger wrote:
> > > It's been almost one week, so I intend to apply soon. As a notice to
> > > everyone who doesn't care about ogg: the patch will also make
> > > av_update_cur_dts in utils.c non-static.
> > A little update since the last patch could still hang forever in some
> > cases.
> > This patch should guarantee that we always make progress.
> Applied with even one more extra check. Maybe a brute-force variant that
> just aborts after some time would have been simpler and just as good.
And how is time measured? I would be extremely annoyed if I had a
program that was using lavf for scripted editing or something like
that involving seeking in ogg source files, and suddenly it failed and
gave horribly wrong output due to massive cpu load (or more likely io
load) from other processes making it take a long time. Deterministic
behavior of the library code should never be broken; your fix was the
right approach. :)
More information about the ffmpeg-devel