[Ffmpeg-devel] swscale and memalign

Luca Abeni lucabe72
Mon Jul 24 09:23:11 CEST 2006

Hi all,

I noticed that my last commit for swscale broke the compilation for
architectures that do not implement memalign.
Let me apologize about that.

A patch like the first attached one (build_fix.diff) seems to fix the
issue. I think it is correct, and I would be tempted to commit it ASAP,
because it fixes a compilation issue. Michael, is it ok?

But looking at the issue, I am wondering if a more radical approach
would be better... I mean, can we replace all the memalign() instances
in swscale.c with av_malloc()? I tried this (see the attached
remove_memalign.diff), and the result seems to be correctly working on
But is this change valid? For example, I see that some of the replaced
memalign() request a 64-bytes alignment, and I do not think av_malloc()
provides it...

Also, out of curiosity: how does this stuff work? If the system does not
provide memalign, malloc is used. And I do not think it can provide a
64-bytes alignment. 

Copy this in your signature, if you think it is important:
                               N O    W A R ! ! !

-------------- next part --------------
A non-text attachment was scrubbed...
Name: build_fix.diff
Type: text/x-patch
Size: 363 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20060724/2a7b318d/attachment.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: remove-memalign.diff
Type: text/x-patch
Size: 7964 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20060724/2a7b318d/attachment-0001.bin>

More information about the ffmpeg-devel mailing list