[Ffmpeg-devel] Re: [xine-devel] Suspicious code in xine-lib CVS from 2006-04-16 18:43

[Benjamin Larsson]

Roberto Togni wrote:

>>>- src/libffmpeg/libavcodec/qdm2.c:541 
>>>
>>>If coding_method[ch][sb][j] - 8 is between 15 and 22 then
>>>coding_method[ch][sb][j] is between 23 and 30 and you access beyond
>>>array bounds here, because switchtable has only 23 entries.
>>>      
>>>
>
>Under checking, even if the author of this part told me that the
>code is never executed for all known samples.
>
>[...]
>  
>
Checked against the assembly. It should be coding_method[ch][sb][j] - 8.

Applied fix.

MvH
Benjamin Larsson

-- 
"incorrect information" is an oxymoron. Information is, by definition, factual, correct.