[Ffmpeg-devel] Re: [patch] const-correctness
Sat Jun 17 17:34:48 CEST 2006
On Sat, Jun 17, 2006 at 05:15:04PM +0200, Baptiste Coudurier wrote:
> Diego Biurrun wrote:
> > On Sat, Jun 17, 2006 at 02:14:51PM +0200, Baptiste COUDURIER wrote:
> >> Michael Niedermayer wrote:
> >>> On Sat, Jun 17, 2006 at 12:28:08AM +0200, Stefan Huehner wrote:
> >>>> attached patch add (mostly) const to variable and parameter declaration,
> >>>> where a char* was used and and 'const char*' should be. Additionally
> >>>> some function declarations are made static if they aren't used outside
> >>>> its declaring source file.
> >>>> Only files under the libavformat directory are affected by this patch.
> >>>> Please review and consider for inclusion.
> >>> patch looks ok assuming it compiles & regression tests pass ...
> >> Compiles fine and pass regression tests here.
> > What's stopping you from committing it then? :)
> Another test from someone on another arch maybe ? :)
for the record. I am working with gcc-4.1 on amd64 and the patch
compiles cleanly here (as i wouldn't have sent it in the first place) and the regression test passes.
But as i'm the submitter perhaps i don't qualify as 'someone' :o)
More information about the ffmpeg-devel