[Ffmpeg-devel] [patch] gcc4 visibility support
Diego 'Flameeyes' Pettenò
Sat Jun 24 20:25:02 CEST 2006
(Luca forwarded me the mail, as I'm not subscribed to ffmpeg-devel)
On Friday 02 June 2006 19:39, Michael Niedermayer wrote:
> is putting EXPORT at the end a good idea readablity wise? IMHO putting
> it before the identifer looks nicer, dunno about portability
I usually put it that way, but does not really change if it's
EXPORTED int exported();
int EXPORTED exported();
int exported() EXPORTED;
all those are fine.
> this variable doesnt exist anymore according to grep
When I prepared the patch, I tried to be as conservative as possible (it's
easier to cut down what's not needed, rather than having to figure out what's
missing), so I simply exported all the symbols in the installed headers. This
also follows the rule that the installed headers should only show the public
API of a library.
Anything that got exported that shouldn't, and anything that got exported and
does not exists, is already shown to the library's users, as they are
included int hose header files. If they should not exported, it would be
better not to let people know of them entirely :)
A few items are exported that are not in the installed headers, those are the
ones needed to let ffmpeg compile and work properly, because of interlibrary
> > Index: ffmpeg-0.4.9-p20060530/configure
> > ===================================================================
> > --- ffmpeg-0.4.9-p20060530.orig/configure
> > +++ ffmpeg-0.4.9-p20060530/configure
> > @@ -417,6 +417,7 @@ os2="yes"
> > ;;
> > *) ;;
> > esac
> > +CFLAGS="$CFLAGS -I\$(BUILD_ROOT)/libavcodec -I\$(BUILD_ROOT)/libavformat
> > -I\$(BUILD_ROOT)/libavutil"
> random unrelated change?
Nop, although I should have explained this.
Basically when I was working on the patch some of the included headers were
picked up from /usr/include, resulting in the non-patched non-exporting
version, so that some symbols gone missing. With this, ffmpeg always prefers
the current copy to the installed one.
Diego "Flameeyes" Petten? - http://farragut.flameeyes.is-a-geek.org/
Gentoo/Alt lead, Gentoo/FreeBSD, Video, AMD64, Sound, PAM, KDE
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Size: 189 bytes
Desc: not available
More information about the ffmpeg-devel