[Ffmpeg-devel] [PATCH] Fix some compiler warnings

Rich Felker dalias
Tue Jun 27 05:05:56 CEST 2006

On Sat, Jun 24, 2006 at 09:07:23PM +0200, Pieter Hollants wrote:
> Hash: SHA1
> M?ns Rullg?rd schrieb:
> >> The point is not to "hide" warnings which are there for a purpose, but
> >> to fix them. Of course not const to non-const, perhaps I missed that
> >> last night. To which hunk are you referring here?
> > 
> > Most of them.
> Right, I'll reinvestigate. But then, though my patches are wrong, it
> means current code ain't right either, right?

No, it means that you should ignore irrelevant compiler warnings. :)
Or at least learn to check if they're relevant rather than throwing
scripted "fixes" at them...

> >> "if(FRAC_BITS < 8)" and throw a #warning in an else-clause, until
> >> someone steps up and fixes the whole thing for FRAC_BITS > 8?
> > 
> > Huh?  C doesn't work like that.
> Sorry, I meant something like assert().
> Or what else would be a correct short-term fix? I understand that for

Absolutely nothing because the code is not broken. FRAC_BITS is 8.


More information about the ffmpeg-devel mailing list