[Ffmpeg-devel] [PATCH] better gdb report on crash in fft.c on mingw.
Thu Jun 29 01:05:54 CEST 2006
On 29/06/06, Benjamin Larsson <banan at student.ltu.se> wrote:
> The bug is valid, this is a configure from mplayer that causes the problem:
> The problem is in the fft init. Removing the line with
> av_freep(&s->exptab); fixes the crash but causes a leak. To correct the
> problem the detection logic needs to be rebuilt. The code finds a simd
> capable cpu but has not the needed headers to set the 3dnow fft routine
> and compile it. (Or atleast something like that). If Zuxy doesn't fix
> the code in a few days I'll do it.
As ordered to on IRC by Benjamin, I hereby submit this patch.
--- libavcodec/fft.c (revision 5538)
+++ libavcodec/fft.c (working copy)
@@ -62,7 +62,11 @@
int has_vectors = 0;
+# ifdef HAVE_MM3DNOW
has_vectors = mm_support() & (MM_3DNOW | MM_3DNOWEXT | MM_SSE
+ has_vectors = mm_support() & (MM_SSE | MM_SSE2);
#if defined(HAVE_ALTIVEC) && !defined(ALTIVEC_USE_REFERENCE_C_CODE)
has_vectors = mm_support() & MM_ALTIVEC;
More information about the ffmpeg-devel