[Ffmpeg-devel] [PATCH] Merge some changes from xine-lib's ffmpeg patch

Michael Niedermayer michaelni
Thu Jun 29 03:09:15 CEST 2006


On Thu, Jun 29, 2006 at 01:59:30AM +0200, Diego 'Flameeyes' Petten? wrote:
> On Thursday 29 June 2006 01:41, Michael Niedermayer wrote:
> > this is silly, the whole function shouldnt be compiled if it cant be, not
> > just returning a incorrect value ...
> I'm not really sure why the condition on that function is put that way, but as 
> it is, it returns a random value, so.. it's surely not 100% right that way 
> either.

our code is buggy in some sense in that case, your patch doesnt fix it
but just hides a warning which points to that buggy code ... this isnt
the correct way to handle bugs or?


> > > +    NULL, NULL, NULL, NULL
> > rejected, this change is random, inconsistent and unneeded
> Uhm, it's not random. 

it is in the sense that it changes one case of hundreads

> It adds the initialisation of the structure members, or 
> they would be uninitialised (as in, random content). 

mans has already explaint that very well ...

> GCC 4 issues a warning 

well yes, i dont doubt it

> > > -#    ifndef DEBUG
> > > +#    if !defined(DEBUG) && !defined(NDEBUG)
> > >  #        define NDEBUG
> > >  #    endif
> > >  #    include <assert.h>
> > what is the purpose of this change?
> Avoids redefinition of NDEBUG if it's already defined.

ok, ive no objection against this one then ...


Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

In the past you could go to a library and read, borrow or copy any book
Today you'd get arrested for mere telling someone where the library is

More information about the ffmpeg-devel mailing list