[Ffmpeg-devel] [PATCH] Merge some changes from xine-lib's ffmpeg patch

Diego 'Flameeyes' Pettenò flameeyes
Thu Jun 29 15:00:37 CEST 2006

On Thursday 29 June 2006 03:09, Michael Niedermayer wrote:
> our code is buggy in some sense in that case, your patch doesnt fix it
> but just hides a warning which points to that buggy code ... this isnt
> the correct way to handle bugs or?
Okay, so I looked more deeply into the code, the function that was removed 
(w_c) requires dwt that is defined in snow.c and thus it is available only on 
Removing w_c from the code requires either removing or dummifying the 
functions w53_8_c, w97_8_c, w53_16_c, w97_16_c, w53_32_c and w97_32_c, some 
of which are used to fill DSPContext::w53 and DSPContext::w97 attributes. The 
only functions called directly of those seems to be w53_32_c and w97_32_c in 
snow.c, while w32 and w97 are used as AVOptions.

So I'm attaching the new patch that removes all those functions when the snow 
encoded is not built, plus it removes the misssing initialisations warning 
that seems to be harmless and tries to clarify the point of setting the 
header's attributes (either that or their usage should be dropped until 
FLAG_SPRITE is correctly handled).

Diego "Flameeyes" Petten? - http://farragut.flameeyes.is-a-geek.org/
Gentoo/Alt lead, Gentoo/FreeBSD, Video, AMD64, Sound, PAM, KDE
-------------- next part --------------
A non-text attachment was scrubbed...
Name: ffmpeg-xine-lib.patch
Type: text/x-diff
Size: 4295 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20060629/411db141/attachment.patch>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20060629/411db141/attachment.pgp>

More information about the ffmpeg-devel mailing list