[Ffmpeg-devel] BUG? ffmpeg option -bug

[Michael Niedermayer]

Hi

On Wed, Mar 01, 2006 at 04:28:00PM +0200, Alex Antropoff wrote:
> On Tue, Feb 28, 2006 at 07:26:11PM +0200, Alex Antropoff wrote:
> AA> Hello, I've tried to use option -bug from command line,
> AA> -bug 8192 to be exactly, but it did not help me.
> AA> Using av_log I see what workaround_bugs got right value, 
> AA> but at h263_encode_init() s->workaround_bugs is 0.
> AA> As I understand it must be set at least to default value, 
> AA> FF_BUG_AUTODETECT(1).
> AA> 
> AA> Cmdline was: 
> AA> ffmpeg -i 1.avi -strict 2 -bug 8192 -level 8 -r 7.5 -ar 22050 -s qcif -b 128 -vcodec mpeg4 -ab 64 -ac 1 -acodec aac 1.3gp
> AA> 
> Ok, I found place where copying  of workaround_bugs was lost.
> Please, commit this fix.
> 
> diff -ru FFMpeg-20060227/libavcodec/mpegvideo.c FFMpeg-20060227.my/libavcodec/mpegvideo.c
> --- FFMpeg-20060227/libavcodec/mpegvideo.c	2006-02-26 16:29:31.000000000 +0200
> +++ FFMpeg-20060227.my/libavcodec/mpegvideo.c	2006-03-01 16:22:01.274693832 +0200
> @@ -961,6 +961,7 @@
>      s->mpeg_quant= avctx->mpeg_quant;
>      s->rtp_mode= !!avctx->rtp_payload_size;
>      s->intra_dc_precision= avctx->intra_dc_precision;
> +    s->workaround_bugs= avctx->workaround_bugs;

rejected, we dont support encoding with bugs

someone feel free to add a assert(avctx->workaround_bugs == 0 or 1) there

[...]
-- 
Michael