[Ffmpeg-devel] [PATCH] GUID is defined in the Windows API (DirectShow)
Wed Mar 1 21:31:48 CET 2006
Rich Felker wrote:
> On Wed, Mar 01, 2006 at 08:24:07AM +0000, M?ns Rullg?rd wrote:
>> Steve Lhomme <slhomme at divxcorp.com> writes:
>>> Michael Niedermayer wrote:
>>>> On Tue, Feb 28, 2006 at 03:33:07PM -1000, Steve Lhomme wrote:
>>>>> ...so this patch renames libavformat's GUID to wGUID. Feel free to
>>>>> rename it to something better if you need.
>>>> #define GUID microsuck_GUID
>>>> around the #inlcude
>>>> or something similar
>>> Impossible, I use the "real" GUID definition in my code too.
>> So replace all your GUID uses with microsuck_GUID too.
> Exactly. Or better yet... LEARN HOW TO FUCKING WRITE MODULAR CODE.
> There is no reason that your code using windows GUIDs should be in the
> same file as code using lavc. If it is you need to go back to school
> and learn a bit about software engineering rather than studying the MS
Wowsa.. I also found that the use of namespaces is good. Since Steve is
using C++, you can wrap the ffmpeg headers in their own namespace or
anything else you want. I had some name comflicts with my project and
some identifiers coming in from avformat.h, and this easily fixed it.
In order to know recursion, you must first know recursion...
More information about the ffmpeg-devel