[Ffmpeg-devel] Re: [PATCH] DVCPRO50 support

Michael Niedermayer michaelni
Mon Mar 6 13:01:28 CET 2006


Hi

On Mon, Mar 06, 2006 at 05:42:26AM -0500, Dan Maas wrote:
> Thank you for the speedy review, Roman!
> 
> > P.S. The main trick was to review your changes with 'diff -b'
> > which cuts down 80% of the indentation related changes ;-)
> 
> Sorry about that... I wasn't sure whether or not to re-indent the big
> blocks that got surrounded by new for() loops :). This should be the
> last such change from me. Just set n_difchan=4 and you've got DV100
> (well, almost :).

they should be reindented but in a seperate cosmetic only patch
(for files maintained by me i would have rejected the cosmetic-functional
mix)

[...]

-- 
Michael





More information about the ffmpeg-devel mailing list