[Ffmpeg-devel] [PATCH] 3DNow! version of FFT
Tue Mar 7 10:52:52 CET 2006
On Mon, Mar 06, 2006 at 07:53:24PM -0800, Corey Hickey wrote:
> Zuxy Meng wrote:
> > --- ffmpeg/libavcodec/i386/fft_3dn.c 1970-01-01 08:00:00.000000000 +0800
> > +++ ffmpeg.new/libavcodec/i386/fft_3dn.c 2006-03-07 08:29:13.000000000 +0800
> > @@ -0,0 +1,138 @@
> > +/*
> > + * FFT/MDCT transform with 3DNow! optimizations
> > + * Copyright (c) 2002 Fabrice Bellard.
> > + * Copyright (c) 2006 Zuxy MENG Jie.
> I was about to apply this, but then I noticed the lines above. Should
> Fabrice's copyright really be on two new fft_3dn files? I gather they
> both started out as copies of fft_sse.c, but I don't know what standard
> operating procedure is in this case. Either way, having "2002" in a
> brand new file seems misleading to me. Something like this might be better:
> * Copyright (c) 2006 Zuxy MENG Jie.
> * Based on fft_sse.c copyright (c) 2002 Fabrice Bellard.
> ...or words to that effect.
Sounds good to me.
More information about the ffmpeg-devel