[Ffmpeg-devel] [patch] Darwin shared object support

Michael Niedermayer michaelni
Tue Mar 7 14:53:04 CET 2006


On Tue, Mar 07, 2006 at 01:54:30PM +0100, Dan Villiom Podlaski Christiansen wrote:
> On 07/03/2006, at 9.29, Michael Niedermayer wrote:
> >well, if the patch contained nothing except the align change, maybe
> >id apply it
> Which particular portion of it do you object to? All of the patch is  
> needed to build FFmpeg for Darwin/x86, or at least something very  
> similar. I don't understand why you want the align change separated  
> from the rest...

cvs policy (http://ffmpeg.sourceforge.net/ffmpeg-doc.html#SEC34) says
split them into self-contained pieces.

it seems to me that the changes to the balign/p2align stuff are 
self-contained, they dont depend on the other changes ...
not to mention that its just automatic search and replace work
to generate that splited patch

and anyway, just picture me as the evil maintainer who wont apply it 
otherwise, look at the MSVC workarounds which where posted they where
nicely split and some got applied, why should we treat apple different
from microsoft?! after all their assembler is broken and thats where
things should be fixed



More information about the ffmpeg-devel mailing list