[Ffmpeg-devel] [PATCH] dv pixel format encoding fix
Thu Mar 9 21:08:22 CET 2006
On Thu, Mar 09, 2006 at 02:26:19PM -0500, Dan Maas wrote:
> > That fixes pix_fmt detection on most dv streams.
> Thanks, this looks good to me.
> > I still have problems with DV in MOV since I could not figure out yet
> > where atp is set in codec encoding functions. Roman could you help me on
> > this one ?
> The problem with DV in MOV is that the packet formatting functions in
> libavformat/dv.c are never called at all.
> (except for a small piece in dvvideo_encode_frame(), which is just a
> hack so that dv_frame_profile() works).
> This is the architecture issue I pointed out earlier. If you want
> fully working DV-in-MOV you will need to do two things:
> 1) Fill in all of the headers. This will involve
> dv_format_frame() and associated functions into the avcodec, and
> calling them from dvvideo_encode_frame().
> 2) Fill in the audio samples. This is the hard one. My first instinct
> is to add a special callback function from the MOV/AVI avformat
> wrappers, to tell the video codec that audio samples are available.
> But I'm not very familiar with the guts of muxing, so perhaps there is
> an easier way.
iam not exactly sure what you propose but its probably not even remotely
ok, let me explain how it should be done, but warning my knowledge about dv
is not as good as it should be so maybe iam missing some details ...
what dv in mov is, is a sick double layer format, its the output of the
dv muxer put into mov, the only sane way to generate this if we really have
to support it and IMHO it would be better if we simply say "NO" to this mess
is to feed the seperate audio and video dv streams into the dv muxer and then
the combined muxed dv stream into the mov muxer, how to implement this
cleanly is not exactly obvious, one way would be to call the dv muxer from
the mov muxer to combine the streams
More information about the ffmpeg-devel