[Ffmpeg-devel] Re: Snow mmx+sse2 asm optimizations
Thu Mar 16 20:20:44 CET 2006
On 3/16/06, Oded Shimon <ods15 at ods15.dyndns.org> wrote:
> On Thu, Mar 16, 2006 at 09:55:26AM -0500, Robert Edele wrote:
> > On Thu, 2006-03-16 at 10:45 +0100, Michael Niedermayer wrote:
> > > Hi
> > >
> > > On Tue, Mar 14, 2006 at 01:44:03PM +0200, Ivan Kalvachev wrote:
> > > > 2006/3/14, Robert Edele <yartrebo at earthlink.net>:
> > > > > On Mon, 2006-03-13 at 02:52 +0100, Michael Niedermayer wrote:
> > > > > > ok, first patch looks mostly ok, iam not particulary happy about
> > > > > > inclusion of snow.h in dsputil.h but i dont really care
> > > > > > as dsputil.h was never supposed to be a public header, so whoever
> > > > > > came up with that idea can fix the snow.h inclusion (installing
> > > > > > along with avcodec.h is not ok)
> > > > >
> > > > > snow.h is included to get access to the DWTELEM #define. Would you
> > > > > any ideas on a better way of doing this?
> > > >
> > > > Maybe right after DCTELEM in dsputil.h ?
> > >
> > > yes, seems like the simplest solution ...
> > Oded, you have my permission to commit it. If you want to fix the
> > snow.h/DWTELEM issue, please post back to the ml before committing,
> > because Michael wasn't too happy with the last fix. Thanks.
> I'm not very keen on committing to ffmpeg, I'm not even subscribed to
> ffmpeg-cvslog, so, could someone else do it?...
> Here's a new patch, no snow.h in dsputil.h...
Applied.... let's hope it doesn't break anything otherwise I can
already picture an 18 wheeler full of cola parking on my living
Reinventing the wheel certainly is annoying, but as long as all other
wheels are square...
More information about the ffmpeg-devel