[Ffmpeg-devel] Re: [PATCH] qt-faststart > 4gb files compliant

[Steve Lhomme]

Mean wrote:
> Mike Melanson wrote:
> 
>> M?ns Rullg?rd wrote:
>>
>>> Baptiste COUDURIER <baptiste.coudurier at smartjog.com> writes:
>>>
>>>
>>>> Mike Melanson wrote:
>>>>
>>>>> Baptiste COUDURIER wrote:
>>>>>
>>>>>
>>>>>> Hi,
>>>>>>
>>>>>> This patch makes qt-faststart 64 bit file offsets compliant.
>>>>>>
>>>>>> Patch to Makefile is to use CFLAGS while compiling qt-faststart, 
>>>>>> to set
>>>>>> _FILE_OFFSET_BITS to 64, define _LARGEFILE_SOURCE
>>>>>
>>>>>
>>>>>
>>>>>    Seriously? Hmm, just looked at the man pages. I never knew ftello()
>>>>> and fseeko() existed. Are the functions really that widespread? Do 
>>>>> they
>>>>> exist on Windows or Mac OS X (not that I care; just curious).
>>>>>
>>>>
>>>> Ok to apply ? I got another patch pending.
>>>
>>>
>>>
>>> Looks good to me, although I'm not either sure about the availablity
>>> of fseeko() on Windows (and neither do I care).
>>
>>
>>     Same. The patch looks sane. Thanks for your effort of this (and 
>> your general interest in QT).
> 
> 
> fseeko & ftello can be emulated on windows using fsetpos/fgetpos and 
> _filelengthi64


But now MinGW build is broken (for qt-faststart)...

Steve