[Ffmpeg-devel] img_convert() ???

[Luca Abeni]

Hi Michael,

On Wed, 2006-03-22 at 13:49 +0100, Michael Niedermayer wrote:
[...]
> > Now, what's the purpose of this img_convert? It seems that it's just
> > copying picture in picture2, No? So, why not using img_copy? Also, why
> > is a copy needed at all? I think I am really missing something here...
> 
> i think that the
> if (do_deinterlace || using_vhook) {
> before this explans half of it
> 
> either we need deinterlacing or we do some filtering with vhook which
> will modify the image IIRC and lavc exports its internal buffers which dont
> like being modified
Ah, ok... I knew I was missing something :)

So, img_copy() seems to be more correct. Is the attached patch ok?

			Thanks,
				Luca
-- 
_____________________________________________________________________________
Copy this in your signature, if you think it is important:
                               N O    W A R ! ! !

 
 
 --
 Email.it, the professional e-mail, gratis per te: http://www.email.it/f
 
 Sponsor:
 Ricevi loghi trendy per il tuo cellulare da Jamba!
 Clicca qui: http://adv.email.it/cgi-bin/foclick.cgi?mid=4846&d=22-3
-------------- next part --------------
A non-text attachment was scrubbed...
Name: remove-unneeded-imgconvert.diff
Type: text/x-patch
Size: 728 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20060322/9961f4b5/attachment.bin>