[Ffmpeg-devel] [PATCH] fix order of operands in test, linking

[Rich Felker]

On Fri, Mar 24, 2006 at 02:13:29AM +0100, Diego Biurrun wrote:
> On Wed, Mar 22, 2006 at 01:01:10AM +0100, Luca Barbato wrote:
> > Diego Biurrun wrote:
> > > On Tue, Mar 21, 2006 at 11:59:16PM +0100, Luca Barbato wrote:
> > >> Patch from Diego Petten? <flameeyes at gentoo.org>
> > >>
> > >> [.. missing explanation ..]
> > > 
> > > I'll care to review when you care to explain...
> > 
> > It should make the test not fail if you have a strict compile/linker
> > that accepts arguments just in the canonical order.
> > 
> > --as-needed option triggers this issue even with binutils.
> 
> I cannot trigger the problem here, but I cannot see how this patch could
> do any harm.  If it fixes stricter systems, it shall be good for us.
> Applied.

Yes, this patch is absolutely necessary with static linking btw.

Rich