[Ffmpeg-devel] More signed fun
Sun Mar 26 15:24:20 CEST 2006
Diego Biurrun <diego at biurrun.de> writes:
> On Thu, Mar 23, 2006 at 10:32:53AM +0000, M?ns Rullg?rd wrote:
>> Steve Lhomme said:
>> > Depending on how your preprocessor handle data, not using () in macros
>> > can lead to problems. Like interpreting (- - variable) (invalid C
>> > syntax)instead of -(-variable). Here is a fix.
>> - -x is perfectly valid C syntax. If your compiler chokes on it,
>> it's broken.
>> That said, the fix is appropriate for other reasons.
> So will you commit it?
Actually, looking closer those parens are not needed at all. The
macro is only used a few times just below the definition, and always
with a single number for each argument. Those parens only add useless
clutter in this case.
mru at inprovide.com
More information about the ffmpeg-devel