[Ffmpeg-devel] movenc.c ipod h264 suggested change

[Jason Millard]

Wow, you run a tight ship.

To be honest, I don't feel it is a hack. It's no worse than any of the
other psp, 3gp flags. And it keeps the exact same coding style...
Beyond that, now the end-user will have to know two cryptic profile
and level settings.

But, since you're the boss, I will look at fetching the values from
AVCodecContext and resubmit a patch.

Thanks for your feedback.
-- Jason Millard


On 3/28/06, Michael Niedermayer <michaelni at gmx.at> wrote:
> Hi
>
> On Tue, Mar 28, 2006 at 03:10:12PM -0500, Jason Millard wrote:
> > I change the code slightly (attached) so there are less changes in the
> > diff. I'm not sure what approach ffmpeg usually goes with.
>
> adding a new "format" just to _hack_ 2 values is not acceptable
> there are profile & level variables in AVCodecContext which should
> be used instead of the hardcoded values
>
> [...]
>
> --
> Michael
>
> _______________________________________________
> ffmpeg-devel mailing list
> ffmpeg-devel at mplayerhq.hu
> http://mplayerhq.hu/mailman/listinfo/ffmpeg-devel
>