[Ffmpeg-devel] [PATCH] last move of functions in vorbis.c to vorbis.h
Sun Oct 1 17:50:38 CEST 2006
On Sun, Oct 01, 2006 at 05:28:12PM +0200, Aurelien Jacobs wrote:
> On Sun, 1 Oct 2006 14:00:12 +0200
> Oded Shimon <ods15 at ods15.dyndns.org> wrote:
> > On Sun, Oct 01, 2006 at 01:54:08PM +0200, Michael Niedermayer wrote:
> > > Hi
> > >
> > > On Sun, Oct 01, 2006 at 01:39:50PM +0200, Oded Shimon wrote:
> > > > last patch necessary for all shared functions (that I noticed).
> > > > One unfortunate thing is I had to remove some debugging printfs from the
> > > > floor function.
> > > >
> > > > render_line() is called quite a bit and during decode, so I made it static
> > > > inline in vorbis.h, gcc refuses to inline it though.
> > > >
> > > > Any objections to commit?
> > >
> > > looks ok
> > Committed with one change, without the inline keyword to avoid annoying
> > warnings... they were given for vorbis_enc.c as well.
> Hum... without the inline keyword it shouldn't go in the .h file IMO.
> It should be shared at the object level...
Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB
In the past you could go to a library and read, borrow or copy any book
Today you'd get arrested for mere telling someone where the library is
More information about the ffmpeg-devel