[Ffmpeg-devel] [PATCH] rename SIGN macro in libavcodec/tta.c

Diego Biurrun diego
Tue Oct 10 01:35:59 CEST 2006


The SIGN macro in libavcodec/tta.c is confusingly named.  It does not
extract the sign or something similar.  I propose renaming it to UNFOLD,
which should come a bit closer to its real meaning.

Diego
-------------- next part --------------
Index: libavcodec/tta.c
===================================================================
--- libavcodec/tta.c	(revision 6614)
+++ libavcodec/tta.c	(working copy)
@@ -352,9 +352,9 @@
                     rice->k0++;
             }
 
-            // extract sign
-#define SIGN(x) (((x)&1) ? (++(x)>>1) : (-(x)>>1))
-            *p = SIGN(value);
+            // extract coded value
+#define UNFOLD(x) (((x)&1) ? (++(x)>>1) : (-(x)>>1))
+            *p = UNFOLD(value);
 
             // run hybrid filter
             ttafilter_process(filter, p, 0);



More information about the ffmpeg-devel mailing list