[Ffmpeg-devel] SIGN Macro

Diego Biurrun diego
Thu Oct 12 01:02:21 CEST 2006


On Wed, Oct 11, 2006 at 06:15:17PM +0800, Colin Ward wrote:
> 
>   What are the generally accepted rules and conventions regarding macros in
> public code?  I just performed an svn update and there is now a SIGN macro
> defined in libavutil/common.h.  ie.
> 
>   #define SIGN(a) ((a) > 0 ? 1 : -1)
> 
>   This clashes with a macro defined in the system headers of my OS so I get
> lots of warnings.  For FFMPEG macros, weren't people usually prefixing them
> with FF_ or something similar, to avoid clashes such as this one?

Fixed.

Diego




More information about the ffmpeg-devel mailing list