[Ffmpeg-devel] H.264 encoder
Thu Oct 12 11:49:13 CEST 2006
On Thu, Oct 12, 2006 at 11:31:39AM +0200, Panagiotis Issaris wrote:
> On Wed, Oct 11, 2006 at 10:09:56PM +0200, Michael Niedermayer wrote:
> > > > probably not -> change pred_non_zero_count() so it takes the top and left
> > > > values as arguments instead of H264Context, or change it so a it takes a
> > > > pointer to non_zero_count_cache ...
> > >
> > > Something like the attached patch does? Or should I drop the const and move left
> > > and top to the outer scope?
> > id move them out as the resulting code is simpler ...
> I've attached two patches, one moving them to the outermost scope (well, within
> the function) and one one scopelevel higher. Which one do you prefer (if any :)
hmm, after reconsidering this, i think its best to forget sharing
pred_non_zero_count() between your encoder and h264.c the result looks
too messy :(
Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB
In the past you could go to a library and read, borrow or copy any book
Today you'd get arrested for mere telling someone where the library is
More information about the ffmpeg-devel