[Ffmpeg-devel] [RFC] TIFF image decoder

[Kostya]

On Thu, Oct 12, 2006 at 10:46:12AM +0200, Michael Niedermayer wrote:
> Hi
> 
> On Wed, Oct 11, 2006 at 05:58:56PM +0300, Kostya wrote:
> > Here is another image format support. For now it's 24-bpp only.
> 
[TGET_* macro -> tget* func]
Done

[RLE]
> 
> one day someone should look through all the rle decoding functions in
> libav* and try to merge them ...
 
Especially when most of them are M$ RLE variants.

> 
> [...]
> > +static int tiff_decode_tag(TiffContext *s, uint8_t *start, uint8_t *buf, uint8_t *end_buf, AVFrame *pic)
> > +{
> > +    int tag, type, count, off, value = 0;
> > +    uint8_t* data = NULL, *src, *dst;
> > +    int i, j, ssize, soff, stride;
> > +
> > +    tag = TGET_SHORT(buf, s->le); buf += 2;
> > +    type = TGET_SHORT(buf, s->le); buf += 2;
> > +    count = TGET_LONG(buf, s->le); buf += 4;
> > +    off = TGET_LONG(buf, s->le); buf += 4;
> 
> if buf isnt used/usefull afterwards (it doesnt seems used) then buf could
> be used instead of data after this
 
Done

[examples of replacing TGET_*]

Done 

Committed with fresh license header and suggested fixes.

> 
> [...]
> -- 
> Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB
> 
> In the past you could go to a library and read, borrow or copy any book
> Today you'd get arrested for mere telling someone where the library is
>